Fix bug where dynamic geometry was not marked as ready #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10517
The above bug was being caused because the bounding sphere was never being computed due to the dynamic geometry never being marked as ready.
This arose after https://github.com/CesiumGS/cesium/pull/10149/files. Previously, when.js would resolve promises synchronously in the same frame. Native promises on the other hand will resolve after a frame. In the case of dynamic geometry, a primitive will have been re-created, so
readyalways appeared to befalseeven if the old promise resolved.Here, instead of waiting on the promise, we check the
readypromise synchronously after each frame.